Update to v4.28.0 - #32
Closed
pimotte wants to merge 11 commits into
Closed
Conversation
…s or equalities. This is done to replace the deprecated cc.
pimotte
marked this pull request as draft
April 30, 2026 18:31
pimotte
marked this pull request as ready for review
May 4, 2026 06:00
Contributor
Author
|
Some benchmarking against the solutions: Results of Same command on v4.27.0, against master of Verbose Lean: Same command on v4.28.0, against impermable/update/v4.28.0 (version with strict grind), with minor modifications to make sheets compile: So if there's a difference, this version is probably slightly faster than the old version/alternative:) |
Merged
Owner
|
Closed in favor of #37. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
I'm not sure if we want to extend the other simp tactics to also be more liberal, that might be too powerful, but I'm happy to implement it, if you think it makes sense.
Unknown:
I think the case for no is: It might cause unexpectedly strong automation.
I think the case for yes is: Not doing so might cause unpredictable behaviour from a student perspective.